-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8361142: Improve custom hooks for makefiles #26060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 454 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@magicus The pull request is being re-evaluated and the inactivity timeout has been reset. |
/integrate |
Going to push as commit 1fc0b01.
Your commit was automatically rebased without conflicts. |
Add some additional and more fine-grained way in which custom makefiles can be integrated.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26060/head:pull/26060
$ git checkout pull/26060
Update a local copy of the PR:
$ git checkout pull/26060
$ git pull https://git.openjdk.org/jdk.git pull/26060/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26060
View PR using the GUI difftool:
$ git pr show -t 26060
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26060.diff
Using Webrev
Link to Webrev Comment