Skip to content

8361142: Improve custom hooks for makefiles #26060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Jul 1, 2025

Add some additional and more fine-grained way in which custom makefiles can be integrated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361142: Improve custom hooks for makefiles (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26060/head:pull/26060
$ git checkout pull/26060

Update a local copy of the PR:
$ git checkout pull/26060
$ git pull https://git.openjdk.org/jdk.git pull/26060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26060

View PR using the GUI difftool:
$ git pr show -t 26060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26060.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361142: Improve custom hooks for makefiles

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 454 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jul 1, 2025
@magicus magicus marked this pull request as ready for review July 1, 2025 12:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2025

@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@magicus
Copy link
Member Author

magicus commented Jul 29, 2025

/touch

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2025
@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@magicus The pull request is being re-evaluated and the inactivity timeout has been reset.

@magicus
Copy link
Member Author

magicus commented Aug 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

Going to push as commit 1fc0b01.
Since your change was applied there have been 490 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2025
@openjdk openjdk bot closed this Aug 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@magicus Pushed as commit 1fc0b01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the better-custom-hooks branch August 11, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants